Skip to content

Add support for lit-css #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2018
Merged

Conversation

web-padawan
Copy link
Contributor

@web-padawan web-padawan commented Oct 25, 2018

lit-css is a new tool to distribute styles via ES modules.
The syntax it uses is exactly the same as used by astroturf added by #37:

import { css } from 'lit-css';

export default css`
  .table {
    /* my default table styles */
  }
`;

Adding the support would allow us to process the CSS in tagged literals used by this library.

This is especially important, as lit-css does not extract styles into .css files, unlike most of tools using similar syntax do. Its output is used as a content for <style> tags used e.g. by lit-html.


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #38   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         403    403           
=====================================
  Hits          403    403
Impacted Files Coverage Δ
extract.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb49e3...73e5a41. Read the comment docs.

@web-padawan
Copy link
Contributor Author

web-padawan commented Oct 25, 2018

Tested and confirmed to work in web-padawan/lit-css-sandbox@22058b1

@gucong3000 gucong3000 merged commit d221849 into gucong3000:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants