Compile with Cabal-3.0 #13
Conversation
Revision checking doesn't work correctly if there are public multi-lib dependencies.
phadej
force-pushed
the
ghc-8.8-cabal-3
branch
from
d6dc3fe to
d504638
Compare
| @@ -89,17 +89,17 @@ executable hackage-cli | |||
| , filepath ^>= 1.4.0.0 | |||
| , http-io-streams ^>= 0.1.0.0 | |||
| , io-streams ^>= 1.5.0.1 | |||
| , lens ^>= 4.17 | |||
| , lens ^>= 4.17 || ^>=4.18 | |||
There was a problem hiding this comment.
fwiw, I'd be fine to support only a single major version (for libraries not bundled w/ GHC); this is an exe after all
There was a problem hiding this comment.
I'll keep in mind that for the future
|
What is preventing this from being merged? |
Mostly a reasonably careful code-review... ;-) |
| @@ -442,28 +454,30 @@ checkDependencies componentName ds1 ds2 = do | |||
|
|
|||
| depKind = depTypeName dproxy ++ " dependency" | |||
|
|
|||
| class (Ord (DepKey d)) => IsDependency d where | |||
| class (Ord (DepKey d), Pretty vr, Eq vr) => IsDependency vr d | d -> vr where | |||
There was a problem hiding this comment.
Out of curiosity, why a functional dependency here where DepKey is an associated type?
|
We should backport what's in |
@phadej, would you have a pointer to what we should port from |
|
After some hints from @hvr, I discovered that this PR was created by copying over |
|
Updated in |
Revision checking doesn't work correctly if there are public multi-lib dependencies.