Updates internals and extensions chapters #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasp85
reviewed
Sep 15, 2021
Comment on lines
+168
to
+171
| # DJN: I'm not sure why, because I can't reproduce the bug elsewhere, but the | ||
| # call to register_theme_element() updates ggplot2:::ggplot_global$element_tree | ||
| # only within *that* chunk, so subsequent chunks don't have ggxyz.panel.annotation | ||
| # in the element tree. For now, this is a hacky fix: |
There was a problem hiding this comment.
hmm... that is weird. But it seems to ultimately be an issue with knitr and how it compartmentalises code - I don't think we should spend too much energy on it right now
Merge commit 'a14ebbd8901d8e95a0859b304c8e19138dcde327' #Conflicts: # extensions.Rmd # internals.Rmd
Co-authored-by: Thomas Lin Pedersen <[email protected]>
Co-authored-by: Thomas Lin Pedersen <[email protected]>
|
I've managed to update this PR to address the original comments, resolved the merge conflicts that were my own fault for leaving it dormant too long, and updated it to accommodate the new linewidth aesthetic. I'm still not happy with it, but it's an improvement on the current state so I'll merge this as-is and seek to fix shortcomings in a new PR |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first pass at smoothing the ggplot2 internals and extensions chapters:
The other big PR in the pipeline at the moment is the scales toolbox edits (#260), and I've checked that this doesn't conflict with that one. I was thinking that since I've already dropped #260 on @hadley, and this is focused on chapters @thomasp85 has worked on, maybe Thomas could take a look at this and make suggestions?