Issue 33 - Implement Testing for RegexPro contributions. #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Hammad,
I have done some work to setup a Jest testing environment and written some tests, specifically focused on pages.js and factory.js.
I have added a TESTING.md document which has configuration and run instructions for the current tests as well as some details about the currently implemented tests. Please feel free to edit or reduce this content at your discretion.
You may want to incorporate the isntruction into CONTRIBUTING.md. (I have added a link in CONTRIBUTING.md at the testing step.)
This is a starting point and only covers the basics of unit testing so far. It was a new challenge for me in best approach to front-end tests for a JS DOM application. There are still a great deal of test scenarios that should be added, especially in terms of UI interaction and user data validation.
I would be happy to continue to work with you on developing more robust testing. Perhaps you can open up a new issue to get some additional contributors to add their experience to the current approach.
Please let me know if I can address any issues with the contribution.
Thanks,
Bryce