Future-proof hapi for node v16, rely on res close rather than req #4225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression in node v15.5.0 which broke hapi. We learned that this was considered a bug in node v15, but that a comparable change would land in node v16. As such, we now rely on res rather than req to handle premature
'close'
events. This small alteration should be compatible with node v12+, and is not considered a breaking change. This relies on a change within shot referenced below.Refs: #4208 hapijs/shot#139 nodejs/node#33035