Skip to content

lib: add new globals from Node.js 15.x #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Conversation

MylesBorins
Copy link
Contributor

This avoids lab failing with Leak errors.

There might be a few other globals that get introduced, not 100%. Might make sense to wait until EOW to confirm the globals.

This avoids lab failing with Leak errors.
Copy link
Member

@Nargonath Nargonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MylesBorins for the PR. Let's wait for the EOW then.

@Nargonath Nargonath added the feature New functionality or improvement label Oct 14, 2020
@richardlau richardlau mentioned this pull request Oct 19, 2020
6 tasks
Co-authored-by: Richard Lau <[email protected]>
@MylesBorins
Copy link
Contributor Author

This seems good to go now 🎉

@geek geek added this to the 24.0.1 milestone Oct 19, 2020
Copy link
Contributor

@kanongil kanongil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but npm@7 that goes with node@15 is not compatible with lab.

The error from CI is:

45 verbose stack TypeError: Cannot read property 'version' of undefined
45 verbose stack     at Arborist.[saveIdealTree] (/home/node-15/.nvm/versions/node/v15.0.0/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:800:33)
45 verbose stack     at /home/node-15/.nvm/versions/node/v15.0.0/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:124:39
45 verbose stack     at async Arborist.reify (/home/node-15/.nvm/versions/node/v15.0.0/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:121:5)
45 verbose stack     at async install (/home/node-15/.nvm/versions/node/v15.0.0/lib/node_modules/npm/lib/install.js:40:5)

It seems that this is because it chooses not to install the 'typescript' dependency. And fails somehow when trying again.

@MylesBorins
Copy link
Contributor Author

@kanongil looking into the npm 7 error now

@richardlau
Copy link
Contributor

@MylesBorins I suspect it's the same issue as npm/cli#1998.

@richardlau
Copy link
Contributor

FWIW I'm able to install/test lab with npm@7 with npm install --legacy-peer-deps but I would not have expected to need to do so.

@kanongil
Copy link
Contributor

I made an npm issue here: npm/cli#2005. It does not appear to be the same as npm/cli#1998.

@geek geek merged commit ea6515c into hapijs:master Oct 22, 2020
@geek
Copy link
Member

geek commented Oct 22, 2020

These changes are now published as 24.1.0. Thank you for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants