Skip to content

MINOR: Remove sanitize filename for reads #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robschn
Copy link

@robschn robschn commented Apr 24, 2025

Fixes #118

@robschn robschn changed the title Remove sanitize filename for reads MINOR: Remove sanitize filename for reads Apr 24, 2025
@mjuraga
Copy link
Collaborator

mjuraga commented May 9, 2025

Hi, Rob, thanks for the PR, I have to look a bit trough history to find out why we were sanitizing filenames like this, but something in the back of my mind thinks because we use those filenames in the Runtime API, and on the URLs as resources names, so we needed them to match in all of these cases as identifiers. Removing file name sanitization completely, makes me a bit uncomfortable and in expectance of regressions popping up. Maybe we could change the function itself to include + if this is a big blocker for you.

@robschn
Copy link
Author

robschn commented May 9, 2025

@mjuraga Appreciate you taking a look! The biggest thing we're running into is loading both RSA and ECDSA files. The HAProxy docs recommend a file structure like cert.pem.rsa and cert.pem.ecdsa and using something like:

crt foobar.pem

This loads both files, but following that naming guideline results in the #118 we're seeing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it necessary to SanitizeFilename()?
2 participants