Enable optional httpHeaders for controller deployment probes #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks @mecampbellsoup, merging! |
dkorunic
added a commit
that referenced
this pull request
May 12, 2021
Changes in kubernetes-ingress: - Add CI tests for extraEnvs - Allow valueFrom usage with controller.extraEnvs (#80) - Allow valueFrom usage with controller.extraEnvs (#79) - Enable optional httpHeaders for controller deployment probes (#78) - support auto-scaling based on custom metrics (#76) Signed-off-by: Dinko Korunic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to configure an external service to be used for any of the
*probes(liveness, readiness, startup) in thecontroller-deployment.Our use-case is that we'd like to define "readiness" of our HAProxy IC to include "able to connect to a specific external service" (a database server, specifically).
This PR adds an optional
httpHeaderskey-values list to the 3 probes' configurable attributes per https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#http-probes.