-
Notifications
You must be signed in to change notification settings - Fork 204
BUG: Make ingress pathType "Exact" always override pathType "Prefix" #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
17d27f7
to
eae6075
Compare
I fixed the broken e2e test and the commit message. Can somebody trigger the tests again? |
The test |
The e2e test failure is odd. I ran |
@phihos I'll check, it wouldn't be the first time CI is misbehaving |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Commenting to remove stale label. And updates on the CI issues? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Comment to remove stale label. |
Hi @phihos , can you check why there's an e2e test failure ? |
Fixes #703.
We introduce a new map
path-prefix-exact
which contains exact match patterns for ingress pathTypePrefix
. From now on the mappath-exact
will only contain patterns from pathTypeExact
. The generated HAProxy config will checkpath-exact
first,path-prefix-exact
second andpath-prefix
third. That way pathTypeExact
always wins.