Skip to content

FFM-11164 Evaluate AND rules #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 15, 2024
Merged

FFM-11164 Evaluate AND rules #149

merged 11 commits into from
Apr 15, 2024

Conversation

erdirowlands
Copy link
Contributor

@erdirowlands erdirowlands commented Apr 14, 2024 •
edited
Loading

What

Supports new AND rules:

  • GroupServingRule is the new rule type sent by the backend. They are:
    • Evaluated by Priority
    • GroupServingRule.Clauses are AND'ed
    • Additional GroupServingRule with lesser priority are OR'd (with their clauses AND'ed).
  • If there are no GroupServingRule to evaluate, then we fall back to the legacy Rule which is OR`d.

Testing

  • Unit tests

@erdirowlands erdirowlands merged commit dffa98c into main Apr 15, 2024
@erdirowlands erdirowlands deleted the FFM-11164 branch April 19, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybharness andybharness andybharness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erdirowlands @andybharness