Fix: Make publishing drafts more robust #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Remove setting `retryClient.RetryMax` to 0 as it has no effect.
jakubbortlik
force-pushed
the
fix-retries-in-gitlab-client
branch
from
df98a1a to
c4ef505
Compare
jakubbortlik
force-pushed
the
fix-retries-in-gitlab-client
branch
from
95ba45f to
d523ea2
Compare
jakubbortlik
changed the title
|
Possible followup: I think it would be useful to do a check_current_branch_up_to_data_on_remote before placing any linked comments/suggestions - this would mean that a |
|
I've merged this separately from the other PRs as this feels higher risk. I'm going to close the related issue but if there are issues that you notice feel free to drop comments here. |
harrisoncramer
pushed a commit
that referenced
this pull request
Apr 14, 2025
harrisoncramer
added a commit
that referenced
this pull request
Apr 14, 2025
harrisoncramer
added a commit
that referenced
this pull request
Jun 25, 2025
* Fix: Jumping to renamed files (#484) * fix: prevent "cursor position outside buffer" error * fix: swap file_name and old_file_name in reviewer data `old_file_name` is not set to the empty string for un-renamed files anymore, because then we can remove the empty-line check in `comment_helpers.go` which was used to replace the empty string with the current file name anyway. * fix: add old_file_name to discussion root node data * fix: also consider old_file_name when jumping to the reviewer This fixes jumping to renamed files, however, may not work for comments that were created on renamed files with the previous version of `gitlab.nvim` as that version assigned the `file_name` and `old_file_name` incorrectly. * refactor: don't shadow variable * fix: check file_name or old_file_name based on which SHA comment belongs to * Fix: Store reviewer data before creating comment popup (#476) * Fix: Make publishing drafts more robust (#483) * Fix: Swap file_name and old_file_name in reviewer data (#485) * Feat: Enable toggling date format between relative and absolute (#491) * Fix: Add opts to help popup (#492) * Fix: Force start_line for jumping to diagnostic to be inside buffer (#494) * fix: redefine colors after reloading colorscheme (#500) * Fix: Use path instead of oldpath as fallback for unrenamed files (#496) * Fix: Use file_name when old_file_name is not set (#495) * fix(ci): fix lua tests (#501) * Proxy Support (#499) This is a #MINOR release. --------- Co-authored-by: Jakub F. Bortlík <[email protected]> Co-authored-by: Jonathan Duck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #425.
By default the gitlab client attempts 5 retries which corresponds to the fact that it bulk publishing drafts "fails" with a server error, it still creates 1+5 copies of the comments.
Apart from finally removing the retry functionality, this MR also introduces the following improves:
gitlab.nvimand publishing them (probably just when there is a comment on some code that has changed).