Do a last polling before closing the IocpProactor

README.rst

@@ -39,7 +39,7 @@ Implementation of the `PEP 3156`_ Event-Loop with Qt
 
 Requirements
 ============
-Quamash requires Python 3.4 or Python 3.3 with the backported ``asycnio`` library and either PyQt4, PyQt5 or PySide.
+Quamash requires Python 3.4 or Python 3.3 with the backported ``asyncio`` library and either PyQt4, PyQt5 or PySide.
 
 Installation
 ============

quamash/__init__.py

@@ -557,6 +557,7 @@ def call_exception_handler(self, context):
 			return
 
 		try:
+			self._logger.debug('Calling client exception handler')
 			self.__exception_handler(self, context)
 		except Exception as exc:
 			# Exception in the user set custom exception handler.

quamash/_windows.py

@@ -39,7 +39,7 @@ def _process_events(self, events):
 				self._logger.debug('Invoking event callback {}'.format(callback))
 				value = callback(transferred, key, ov)
 			except OSError as e:
-				self._logger.warn('Event callback failed: {}'.format(e))
+				self._logger.warning('Event callback failed: {}'.format(e))
 				f.set_exception(e)
 			else:
 				f.set_result(value)
@@ -70,15 +70,19 @@ def select(self, timeout=None):
 
 	def close(self):
 		self._logger.debug('Closing')
+		self._poll(0.2)
 		super(_IocpProactor, self).close()
 
 	def _poll(self, timeout=None):
 		"""Override in order to handle events in a threadsafe manner."""
 		if timeout is None:
 			ms = UINT32_MAX  # wait for eternity
-		elif timeout < 0:
-			raise ValueError("negative timeout")
 		else:
+			if not isinstance(timeout, (int, float)):
+				raise TypeError('timeout must be a number')
+			if timeout < 0:
+				raise ValueError("negative timeout")
+
 			# GetQueuedCompletionStatus() has a resolution of 1 millisecond,
 			# round away from zero to wait *at least* timeout seconds.
 			ms = math.ceil(timeout * 1e3)
@@ -88,8 +92,14 @@ def _poll(self, timeout=None):
 		while True:
 			# self._logger.debug('Polling IOCP with timeout {} ms in thread {}...'.format(
 			# 	ms, threading.get_ident()))
+			if self._iocp is None:
+				self._logger.debug('Stopping polling since IOCP handle is disposed')
+				break
+
+			assert 0 <= ms <= UINT32_MAX
 			status = _overlapped.GetQueuedCompletionStatus(self._iocp, ms)
 			if status is None:
+				self._logger.debug('Stopping polling since None was returned for status')
 				break
 
 			err, transferred, key, address = status