Showcase: convert PopoverPrimitive page to gts #3179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shleewhite
force-pushed
the
hds-5384/showcase-popover-primitive-gts
branch
from
0044221 to
1d04231
Compare
shleewhite
force-pushed
the
hds-5384/showcase-popover-primitive-gts
branch
from
51584b8 to
01e0d96
Compare
dchyun
previously approved these changes
Sep 16, 2025
.../app/components/page-utilities/popover-primitive/code-fragments/with-placeholder-trigger.gts
Show resolved
Hide resolved
shleewhite
force-pushed
the
hds-5384/showcase-popover-primitive-gts
branch
from
b738484 to
e47f63b
Compare
dchyun
reviewed
Sep 17, 2025
showcase/app/components/page-utilities/popover-primitive/code-fragments/with-button-trigger.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-utilities/popover-primitive/code-fragments/with-button-trigger.gts
Outdated
Show resolved
Hide resolved
shleewhite
force-pushed
the
hds-5384/showcase-popover-primitive-gts
branch
from
e47f63b to
3c071d7
Compare
dchyun
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would convert the PopoverPrimitive page to gts.
There are also a few changes to Percy:
🔗 External links
Jira ticket: HDS-5384
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.