Skip to content

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Sep 15, 2025

📌 Summary

If merged, this PR updates all imports of the @ember/service module's service decorator
from:

import { inject as service } from '@ember/service';

to:

import { inject } from '@ember/service';

📸 Screenshots

image

🔗 External links

Jira ticket: HDS-4945


📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Sep 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Sep 18, 2025 6:17pm
hds-website Ready Ready Preview Sep 18, 2025 6:17pm

@hashibot-hds hashibot-hds added packages/components docs-website Content updates to the documentation website showcase labels Sep 15, 2025
@zamoore zamoore marked this pull request as ready for review September 15, 2025 00:34
@zamoore zamoore requested review from a team as code owners September 15, 2025 00:34
shleewhite
shleewhite previously approved these changes Sep 15, 2025
@alex-ju alex-ju added this to the [email protected] milestone Sep 15, 2025
Copy link
Contributor

@shleewhite shleewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need a changelog, bc theres no change for an end user right?

@zamoore
Copy link
Contributor Author

zamoore commented Sep 19, 2025

This doesn't need a changelog, bc theres no change for an end user right?

That's my inclination. This feels like it would be useless clutter in a changelog. @alex-ju can you weigh in?

@zamoore zamoore force-pushed the main-5.0.0 branch 2 times, most recently from 7c0bc36 to 81a4cea Compare September 19, 2025 19:19
@zamoore zamoore merged commit 67abae4 into main-5.0.0 Sep 22, 2025
16 checks passed
@zamoore zamoore deleted the fix-service-injection-warning branch September 22, 2025 14:01
zamoore added a commit that referenced this pull request Sep 22, 2025
zamoore added a commit that referenced this pull request Sep 22, 2025
zamoore added a commit that referenced this pull request Sep 22, 2025
zamoore added a commit that referenced this pull request Sep 22, 2025
zamoore added a commit that referenced this pull request Sep 23, 2025
zamoore added a commit that referenced this pull request Sep 23, 2025
zamoore added a commit that referenced this pull request Sep 24, 2025
zamoore added a commit that referenced this pull request Sep 30, 2025
zamoore added a commit that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website packages/components showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants