Skip to content

Web docs - Adding loading state guidance to button docs. #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Web docs - Adding loading state guidance to button docs. #3185

wants to merge 7 commits into from
+20 −1

Conversation

majedelass
Copy link
Contributor

@majedelass majedelass commented Sep 15, 2025 •
edited
Loading

📌 Summary

If merged, this PR will add a new section in the button doc providing guidance for loading states.

🔗 External links

Jira ticket: HDS-5388

💬 Please consider using conventional comments when reviewing this PR.

@vercel Vercel
Copy link

vercel bot commented Sep 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Sep 16, 2025 1:47pm
hds-website Ready Ready Preview Sep 16, 2025 1:47pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Sep 15, 2025
@majedelass majedelass marked this pull request as ready for review September 15, 2025 18:07
@majedelass majedelass requested review from a team as code owners September 15, 2025 18:07
heatherlarsen
heatherlarsen reviewed Sep 15, 2025
View reviewed changes
didoo
didoo previously approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just a quick question, non blocker: do we want to offer any guidance on what should be the label of the button, when in loading state? "Do something" → "Doing" / "Loading" / "Processing" / other?

@majedelass
Copy link
Contributor Author

👍

Just a quick question, non blocker: do we want to offer any guidance on what should be the label of the button, when in loading state? "Do something" → "Doing" / "Loading" / "Processing" / other?

Let me think on this for a few and ill see what we can suggest (if anything).

heatherlarsen
heatherlarsen approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@heatherlarsen heatherlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick adjustments!

@majedelass
Copy link
Contributor Author

👍

Just a quick question, non blocker: do we want to offer any guidance on what should be the label of the button, when in loading state? "Do something" → "Doing" / "Loading" / "Processing" / other?

I'm going to omit for this round since it's context based.

@majedelass majedelass requested a review from didoo September 17, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heatherlarsen heatherlarsen heatherlarsen approved these changes

@didoo didoo Awaiting requested review from didoo

Assignees
No one assigned
Labels
docs-website Content updates to the documentation website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@majedelass @didoo @heatherlarsen @hashibot-hds