Skip to content

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Sep 17, 2025

📌 Summary

If merged, this PR would convert the Components > Breadcrumb route to the gts format.

Notice: the diff in Percy is because I've added two dividers between the sections

🔗 External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-5332


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@didoo didoo requested a review from a team as a code owner September 17, 2025 12:02
Copy link

vercel bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Sep 17, 2025 4:14pm
hds-website Ready Ready Preview Sep 17, 2025 4:14pm

Copy link
Contributor

@shleewhite shleewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just had the one suggestion.

shleewhite
shleewhite previously approved these changes Sep 17, 2025
Copy link
Contributor

@shleewhite shleewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just had the one suggestion.

@didoo didoo merged commit 83fc30a into main Sep 17, 2025
28 of 30 checks passed
@didoo didoo deleted the breadcrumb-gts-conversion branch September 17, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants