-
Notifications
You must be signed in to change notification settings - Fork 51
Showcase: Convert Breadcrumb to gts #3196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6647b34
to
23ee607
Compare
ac4ab04
to
b24d6b7
Compare
b24d6b7
to
5f826c2
Compare
5f826c2
to
c4d476b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just had the one suggestion.
showcase/app/components/page-components/breadcrumb/code-fragments/with-mock-states.gts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just had the one suggestion.
92b57ff
to
66ab1e3
Compare
📌 Summary
If merged, this PR would convert the
Components > Breadcrumb
route to the gts format.Notice: the diff in Percy is because I've added two dividers between the sections
🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-5332
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.