This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Operator api #85
Merged
Operator api #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated generator/status.go * updated generator/status.go * added v1/status.go and v1/status_test.go, tests passing * Add support for required TLS and ACL envars. (hashicorp#75) * Add support for required TLS and ACL envars. * Add macOS compiler flags to make building happy on BigSur. * Update Nomad version. * Fix ruby config and regenerate client (hashicorp#80) * updated generator/status.go * updated generator/status.go * added v1/status.go and v1/status_test.go, tests passing Co-authored-by: Derek Strickland <[email protected]>
…figuration working
|
@DerekStrickland I've pushed the latest commits with the 2 new working tests. You should already be a collaborator for my fork. |
|
@Neutrollized Fantasic! I'll take a gander. |
…figuration working
|
Ok, I think we're g2g now, @DerekStrickland ! |
DerekStrickland
suggested changes
Feb 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @DerekStrickland ,
I've been struggling with the Operator API a bit and will need you help in completing this.
In
generator/operator.go, the following are not implemented:In
v1/operator_tests.go, I have tests written for everything else, but also have a bunch commented out due to errors that I'm unsure of how to handle.