This repository was archived by the owner on Dec 9, 2020. It is now read-only.
Add support for 'domain_aliases' #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can now support a list of domain aliases:
```
resource "netlify_site" "site" {
[...]
domain_aliases = [
"www1.example.com",
"www2.example.com",
]
}
```
Fixes hashicorp#29
ghost
added
|
HI we depend on the domain aliases Netlify feature and would love to be able to use Terraform for it. Is there some way I can help get this merged? I can verify this PR code works well. |
|
Any update? |
|
Bump, any update on this? |
paultyng
reviewed
Apr 17, 2020
| @@ -27,6 +27,11 @@ func resourceSite() *schema.Resource { | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
| }, | |||
| "domain_aliases": { | |||
| Type: schema.TypeList, | |||
There was a problem hiding this comment.
Should this be a set, or does the order matter here?
There was a problem hiding this comment.
I don't think order really matters in this scenario
|
Hello @paultyng. How can I help get this merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now support a list of domain aliases:
Fixes #29