Support conditions in action triggers #37485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
added
the
no-changelog-needed
DanielMSchmidt
force-pushed
the
TF-27460
branch
4 times, most recently
from
917b227 to
768e723
Compare
DanielMSchmidt
force-pushed
the
TF-27460
branch
2 times, most recently
from
7d8d086 to
d510795
Compare
DanielMSchmidt
force-pushed
the
TF-27460
branch
3 times, most recently
from
ab10206 to
ae9ee37
Compare
DanielMSchmidt
force-pushed
the
TF-27460
branch
2 times, most recently
from
57fbdb1 to
154b9ce
Compare
liamcervante
reviewed
Sep 1, 2025
DanielMSchmidt
force-pushed
the
TF-27460
branch
from
fa83a1a to
d4a23cb
Compare
we don't really care about the expansion in this context
Co-authored-by: Liam Cervante <[email protected]>
DanielMSchmidt
force-pushed
the
TF-27460
branch
from
d4a23cb to
254c057
Compare
liamcervante
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for conditions in lifecycle action_trigger blocks. Conditions can only contain
count.index,each.key,each.value, andselfif the action_trigger events list does not contain abefore_*action since we don't know the values for these things at that point in time.Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry