Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Compilation failure while using GHC 9.2.1-rc1 #554

Closed
kgardas opened this issue Sep 20, 2021 · 8 comments
Closed

Compilation failure while using GHC 9.2.1-rc1 #554

kgardas opened this issue Sep 20, 2021 · 8 comments

Comments

@kgardas
Copy link

kgardas commented Sep 20, 2021

Attempt to compile basement with ghc 9.2.1-rc1 on ubuntu 20.04.x on amd64 reveals following issue:

[19 of 84] Compiling Basement.Numerical.Conversion ( Basement/Numerical/Conversion.hs, /export/home/karel/vcs/haskell-libraries/foundation/basement/dist-newstyle/build/x86_64-linux/ghc-9.2.0.20210821/basement-0.0.12/build/Basement/Numerical/Conversion.o, /export/home/karel/vcs/haskell-libraries/foundation/basement/dist-newstyle/build/x86_64-linux/ghc-9.2.0.20210821/basement-0.0.12/build/Basement/Numerical/Conversion.dyn_o )

Basement/Numerical/Conversion.hs:84:46: error:
    • Couldn't match expected type ‘Word32#’ with actual type ‘Word#’
    • In the first argument of ‘W32#’, namely
        ‘(uncheckedShiftRL# w64 32#)’
      In the first argument of ‘Word32x2’, namely
        ‘(W32# (uncheckedShiftRL# w64 32#))’
      In the expression:
        Word32x2
          (W32# (uncheckedShiftRL# w64 32#)) (W32# (narrow32Word# w64))
   |
84 | word64ToWord32s (W64# w64) = Word32x2 (W32# (uncheckedShiftRL# w64 32#)) (W32# (narrow32Word# w64))
   |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^

Basement/Numerical/Conversion.hs:84:81: error:
    • Couldn't match expected type ‘Word32#’ with actual type ‘Word#’
    • In the first argument of ‘W32#’, namely ‘(narrow32Word# w64)’
      In the second argument of ‘Word32x2’, namely
        ‘(W32# (narrow32Word# w64))’
      In the expression:
        Word32x2
          (W32# (uncheckedShiftRL# w64 32#)) (W32# (narrow32Word# w64))
   |
84 | word64ToWord32s (W64# w64) = Word32x2 (W32# (uncheckedShiftRL# w64 32#)) (W32# (narrow32Word# w64))
   |                                                                                 ^^^^^^^^^^^^^^^^^
@sjakobi
Copy link

sjakobi commented Sep 20, 2021

This head.hackage patch probably fixes the issue, but I haven't checked.

@josephcsible
Copy link

I can confirm that it builds fine on 9.2.1 with that patch.

@TomMD
Copy link

TomMD commented Oct 31, 2021

I took this patch and made draft PR 555. Hopefully the maintainer will chime in with what form they'd find appealing. I'm sure the HackageHead module isn't it.

@LeventErkok
Copy link

Looks like Gauge depends on basement, which causes most of benchmark suites fail to compile with GHC 9.2.1; would be great basement got a GHC 9.2.1 release.

@LeventErkok LeventErkok mentioned this issue Nov 11, 2021
Closed
sjakobi added a commit to sjakobi/store that referenced this issue Nov 16, 2021
@sjakobi
Remove build with GHC 9.2
9c34bea 
Due to haskell-foundation/foundation#554.
@sjakobi
Copy link

sjakobi commented Nov 16, 2021

Looks like Gauge depends on basement, which causes most of benchmark suites fail to compile with GHC 9.2.1

gauge users can also consider switching to tasty-bench which is currently maintained more actively.

sjakobi added a commit to sjakobi/store that referenced this issue Nov 16, 2021
@sjakobi
Add CI with GitHub Actions via haskell-ci
8c93e07 
Fixes mgsloan#166.

* GHC 8.10 is excluded due to mgsloan#165.

* `build-tools` are added for compatibility with `cabal test`

* Require time >= 1.5. With time-1.4.2, the build fails:

      Not in scope: type constructor or class ‘Time.TimeLocale’

* GHC 7.8 is excluded because the bound `time >= 1.5` leads to
  dependency resolution issues here.

* GHC 9.2 is excluded due to
  haskell-foundation/foundation#554.
@sjakobi sjakobi mentioned this issue Nov 16, 2021
Merged
@LeventErkok LeventErkok mentioned this issue Nov 16, 2021
Closed
mgsloan pushed a commit to mgsloan/store that referenced this issue Nov 17, 2021
@sjakobi @mgsloan
Add CI with GitHub Actions via haskell-ci
34b7a83 
Fixes #166.

* GHC 8.10 is excluded due to #165.

* `build-tools` are added for compatibility with `cabal test`

* Require time >= 1.5. With time-1.4.2, the build fails:

      Not in scope: type constructor or class ‘Time.TimeLocale’

* GHC 7.8 is excluded because the bound `time >= 1.5` leads to
  dependency resolution issues here.

* GHC 9.2 is excluded due to
  haskell-foundation/foundation#554.
This was referenced Nov 18, 2021
Closed
Closed
@LaurentRDC
Copy link

LaurentRDC commented Nov 24, 2021 •
edited
Loading

This head.hackage patch probably fixes the issue, but I haven't checked.

How do I make use of this patch? I can't just cabal build can I?

Edit: Here it is

@andrewufrank
Copy link

basement is used for several packages, e.g. snap which do not compile with 9.2.1. I see the exact same errors as mentioned initially - 4 month later.
Could you please put a patched version to hackage? Thank you!

@maerten
Copy link

maerten commented Mar 3, 2022

this issue seems to be fixed in 0.0.13

mengwong added a commit to smucclaw/gf-core that referenced this issue Dec 1, 2022
@mengwong
fixed as many "monad of no return" as I could
92d0edb 
this leaes haskell-foundation/foundation#554
@vincenthz vincenthz closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@TomMD @vincenthz @maerten @LeventErkok @kgardas @andrewufrank @sjakobi @josephcsible @LaurentRDC