Implement HasForeign instance #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the generated javascript to do multipart MIME file uploads.
It is the user's responsibility to generate a valid body; e.g.:
var fileObject = new File([blob], 'video.webm', {
type: 'video/webm'
});
var formData = new FormData();
formData.append('video', fileObject);
postVideo(formData, onSuccess, onError);
phadej
reviewed
Sep 17, 2018
src/Servant/JS/Vanilla.hs
Outdated
| @@ -34,7 +34,7 @@ generateVanillaJSWith opts req = "\n" <> | |||
| <> " xhr.open('" <> decodeUtf8 method <> "', " <> url <> ", true);\n" | |||
| <> reqheaders | |||
| <> " xhr.setRequestHeader('Accept', 'application/json');\n" | |||
| <> (if isJust (req ^. reqBody) then " xhr.setRequestHeader('Content-Type', 'application/json');\n" else "") | |||
| <> (if isJust (req ^. reqBody) && (req ^. reqBodyIsJSON) then " xhr.setRequestHeader('Content-Type', 'application/json');\n" else "") | |||
There was a problem hiding this comment.
what about non-Vanilla drivers?
There was a problem hiding this comment.
I don't use them and didn't implement anything for them.
alpmestan
approved these changes
Oct 10, 2018
|
It would be nice to support other drivers, but worst case I'll just implement something similar for them if you don't feel like doing it yourself. |
|
I'll verify that things work together when I'll make servant-0.15 (hopefully this week). Thanks for you contribution, @afcady |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is three patches, to
servant-foreign,servant-multipart, andservant-js.https://github.com/haskell-servant/servant-multipart/compare/master...afcady:multipart-foreign?expand=1
https://github.com/haskell-servant/servant/compare/master...afcady:multipart-foreign?expand=1
https://github.com/haskell-servant/servant-js/compare/master...afcady:multipart-foreign?expand=1
The patch to
servant-foreignadds a Boolean field to theReqtype specifying whether the request body is JSON (as is currently assumed). The patch toservant-multipartimplements a HasForeign instance that sets this field toFalse. The patch toservant-jschanges the output ofvanillaJSwhen the flag is false, so thatJSON.stringify()does not get called on the body and the content-type is not set to JSON.This address haskell-servant/servant-multipart#5