Skip to content

alterF: Skip deleting the key when it's already absent #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

alterF: Skip deleting the key when it's already absent #288

merged 1 commit into from
Jul 21, 2020

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Jul 21, 2020

Fixes #287.

@sjakobi sjakobi mentioned this pull request Jul 21, 2020
Closed
@treeowl
Copy link
Collaborator

treeowl commented Jul 21, 2020

Note: we already do this right in the rule-rewritten alterFEager.

@sjakobi sjakobi merged commit f508e18 into master Jul 21, 2020
@sjakobi sjakobi deleted the sjakobi/287-alterF-skip-delete branch July 21, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treeowl treeowl treeowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alterF: No need to delete when the key is absent?!
2 participants
@sjakobi @treeowl