Skip to content

Conversation

marcosh
Copy link
Contributor

@marcosh marcosh commented Mar 26, 2021

this PR adds mapKeys to the API, following the implementation provided by containers.

I'm not an expert in performances and on the internals of unordered-containers, so feel free to refuse this if it is not up to the standards of the library

@marcosh
Copy link
Contributor Author

marcosh commented Mar 29, 2021

@sjakobi I addressed your recommendations. Should be ready now

Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor rewording, LGTM apart from that.

@sjakobi sjakobi requested review from treeowl and emilypi March 29, 2021 11:43
@sjakobi sjakobi merged commit 339866b into haskell-unordered-containers:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants