Skip to content

Add js-options field so that user-defined options can be passed to javascript preprocessor #10721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Swordlash opened this issue Jan 6, 2025 · 2 comments
Open

Add js-options field so that user-defined options can be passed to javascript preprocessor #10721

Swordlash opened this issue Jan 6, 2025 · 2 comments
Assignees
@Swordlash
Labels
type: enhancement

Comments

@Swordlash
Copy link

Describe the feature request
See the GHC ticket and description of the issue: https://gitlab.haskell.org/ghc/ghc/-/issues/25632#note_602729

There seems to be currently no way to pass JS CPP options for js-sources, like defining your own macros.

Additional context
This would enable things like TRACE flags in libraries that conditionally compile logging directives, for instance.
@Mikolaj
Copy link
Member

Mikolaj commented Jan 6, 2025

Is this a newcomer ticket (if so, let's label it so), or can there be anything tricky, either in implementation or testing (I guess no testing is possible at all with our current CI?)?

@Swordlash
Copy link
Author

@Mikolaj Looks easy enough, can you assign me?

Swordlash added a commit to Swordlash/cabal that referenced this issue Jan 6, 2025
@Swordlash
Add js-sources field to cabal file to allow passing custom preprocess…
eca0d2e 
…ing options for js (haskell#10721)
@Swordlash Swordlash mentioned this issue Jan 6, 2025
Open
Mikolaj pushed a commit to Swordlash/cabal that referenced this issue Feb 1, 2025
@Swordlash @Mikolaj
Add js-sources field to cabal file to allow passing custom preprocess…
27fec1c 
…ing options for js (haskell#10721)
zlonast added a commit to zlonast/cabal that referenced this issue May 12, 2025
@zlonast
ghc-options added to js, cmm and asm
54f0e09 
add GhcOptions test

partial fix for haskell#10721
zlonast added a commit to zlonast/cabal that referenced this issue May 18, 2025
@zlonast
ghc-options added to js, cmm and asm
c9935c4 
add GhcOptions test

partial fix for haskell#10721
zlonast added a commit to zlonast/cabal that referenced this issue May 19, 2025
@zlonast
Add jsp-options (haskell#10721)
075f4d3 
Co-authored-by: Swordlash [email protected]
@zlonast zlonast mentioned this issue May 19, 2025
Open
zlonast added a commit to zlonast/cabal that referenced this issue May 19, 2025
@zlonast @Swordlash
Add jsp-options (haskell#10721)
df09931 
Co-authored-by: Mateusz Goslinowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Swordlash Swordlash

Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mikolaj @Swordlash