Test suite fails due to rpath changes

[tibbe]

There are several test failures (that I unfortunately missed before merging) related to rpath. These need to be fixed before the 1.22 release or we'll need to roll back the rpath changes. @christiaanb can you please take a look. This was most likely introduced by #2255.

  WithHpc-LibProfExeDynShared:
    : [Failed]
expected: 'setup test' should succeed
  output: "/Users/tibell/src/cabal/Cabal/tests/Setup --builddir=dist-WithHpc-LibProfExeDynShared test" in PackageTests/TestSuiteExeV10
Running 1 test suites...
Test suite test-Foo: RUNNING...
dyld: Library not loaded: @rpath/libHSmy-0.1-ghc7.8.3.dylib
  Referenced from: /Users/tibell/src/cabal/Cabal/tests/PackageTests/TestSuiteExeV10/dist-WithHpc-LibProfExeDynShared/build/test-Foo/test-Foo
  Reason: image not found
Test suite test-Foo: FAIL
Test suite logged to:
dist-WithHpc-LibProfExeDynShared/test/my-0.1-test-Foo.log
0 of 1 test suites (0 of 1 test cases) passed.

  WithHpc-LibProfExeDyn:
    : [Failed]
expected: 'setup test' should succeed
  output: "/Users/tibell/src/cabal/Cabal/tests/Setup --builddir=dist-WithHpc-LibProfExeDyn test" in PackageTests/TestSuiteExeV10
Running 1 test suites...
Test suite test-Foo: RUNNING...
dyld: Library not loaded: @rpath/libHSmy-0.1-ghc7.8.3.dylib
  Referenced from: /Users/tibell/src/cabal/Cabal/tests/PackageTests/TestSuiteExeV10/dist-WithHpc-LibProfExeDyn/build/test-Foo/test-Foo
  Reason: image not found
Test suite test-Foo: FAIL
Test suite logged to: dist-WithHpc-LibProfExeDyn/test/my-0.1-test-Foo.log
0 of 1 test suites (0 of 1 test cases) passed.

  WithHpc-ExeDynShared:
    : [Failed]
expected: 'setup test' should succeed
  output: "/Users/tibell/src/cabal/Cabal/tests/Setup --builddir=dist-WithHpc-ExeDynShared test" in PackageTests/TestSuiteExeV10
Running 1 test suites...
Test suite test-Foo: RUNNING...
dyld: Library not loaded: @rpath/libHSmy-0.1-ghc7.8.3.dylib
  Referenced from: /Users/tibell/src/cabal/Cabal/tests/PackageTests/TestSuiteExeV10/dist-WithHpc-ExeDynShared/build/test-Foo/test-Foo
  Reason: image not found
Test suite test-Foo: FAIL
Test suite logged to: dist-WithHpc-ExeDynShared/test/my-0.1-test-Foo.log
0 of 1 test suites (0 of 1 test cases) passed.

  WithHpc-ExeDyn:
    : [Failed]
expected: 'setup test' should succeed
  output: "/Users/tibell/src/cabal/Cabal/tests/Setup --builddir=dist-WithHpc-ExeDyn test" in PackageTests/TestSuiteExeV10
Running 1 test suites...
Test suite test-Foo: RUNNING...
dyld: Library not loaded: @rpath/libHSmy-0.1-ghc7.8.3.dylib
  Referenced from: /Users/tibell/src/cabal/Cabal/tests/PackageTests/TestSuiteExeV10/dist-WithHpc-ExeDyn/build/test-Foo/test-Foo
  Reason: image not found
Test suite test-Foo: FAIL
Test suite logged to: dist-WithHpc-ExeDyn/test/my-0.1-test-Foo.log
0 of 1 test suites (0 of 1 test cases) passed.

To reproduce on OS X 10.9.5:

git clone https://github.com/haskell/cabal.git
cd cabal/Cabal
cabal sandbox init
# I have library-profiling profiling on by default in my ~/.cabal/config
cabal install --only-dep --enable-tests --disable-library-profiling
cabal test

[tibbe]

Fixed by #2289.