Always setup (DY)LD_LIBRARY_PATH for testsuite #2289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Cabal is in charge of RPATH handling on certain OS', we must always setup a correct (DY)LD_LIBRARY_PATH when running the testsuite. Not just when we are building relocatable packages. The "problem" is, is that Cabal now adds an RPATH pointing to the installation location of the library. However, during testing, the library won't be there yet. We much hence setup a (DY)LD_LIBRARY_PATH that includes the dist/build dir.
Merged
thomie
added a commit
to thomie/cabal
that referenced
this pull request
Jul 8, 2016
…executable-dynamic Since commit 18fcd9c, Cabal builds the stub executable and the test library for a LibV09 (detailed-0.9) test in different directories. This is good, but when running the test with --enable-executable-dynamic, we now have to add the test build directory to (DY)LD_LIBRARY_PATH, so that the linker can find the test library when running the stub executable (see haskell#2289 for details). This fixes haskell#2039. The GHC panic mentioned in that ticket must have been resolved earlier already.
thomie
added a commit
to thomie/cabal
that referenced
this pull request
Jul 8, 2016
Since commit 18fcd9c, Cabal builds the stub executable and the test library for a LibV09 (detailed-0.9) test in different directories. This is good, but when running the test with --enable-executable-dynamic, we now have to add the test build directory to (DY)LD_LIBRARY_PATH, so that the linker can find the test library when running the stub executable (see haskell#2289 for details). This fixes haskell#2039 (read: no parse). The GHC panic mentioned in that ticket must have been resolved earlier already, perhaps also by commit 18fcd9c.
thomie
added a commit
to thomie/cabal
that referenced
this pull request
Jul 8, 2016
Since commit 18fcd9c, Cabal builds the stub executable and the test library for a LibV09 (detailed-0.9) test in different directories. This is good, but when running the test with --enable-executable-dynamic, we now have to add the test build directory to (DY)LD_LIBRARY_PATH, so that the linker can find the test library when running the stub executable (see haskell#2289 for details). This fixes haskell#2039 (read: no parse). The GHC panic mentioned in that ticket must have been resolved earlier already, perhaps also by commit 18fcd9c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Cabal is in charge of RPATH handling on certain OS',
we must always setup a correct (DY)LD_LIBRARY_PATH when
running the testsuite. Not just when we are building relocatable
packages.
The "problem" is, is that Cabal now adds an RPATH pointing
to the installation location of the library. However, during
testing, the library won't be there yet. We much hence setup
a (DY)LD_LIBRARY_PATH that includes the dist/build dir.