-
Notifications
You must be signed in to change notification settings - Fork 710
Passing arguments to test suites run via new-test is unsupported #4643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This probably also affects |
Just bumped into this the other day. I think that none of the flags specific to old-test ( |
Apparently some are set to |
in the meantime..
which probably is brittle and breaks if you build tests with and without optimizations at some point.. |
@lspitzner less brittle: use |
Continuing on #3638 (comment), That's because @hvr's example uses (currently) incorrect syntax. As with
The first This correctly parses as ["test-name","other-test","--","--test-flags","and","test","args"] Edit: well, maybe the current syntax wasn't intended to be used like this? |
Let me offer one more unsolicited suggestion: maybe |
I somewhat sympathize with @ezyang's suggestion; it would probably make things simpler and less surprising. However, we still want the ability to say |
Yes, there should be a way to run all tests (in project/package) without knowing the test-suite names. |
Partially fixed with #4861 (new-run can now run tests/benchs and it can pass arguments). new-test still cannot pass arguments. |
I'd love to see a fix for this! I think the |
This means that old `test` flags can be passed in to `new-test`, `new-build`, `new-install`, `new-configure`, etc. These new flags are: * `--test-log` (see old `--log`) * `--test-machine-log` (see `--machine-log`) * `--test-show-details` (see `--show-details`) * `--test-keep-tix-files` (see `--keep-tix-files`) * `--test-options` * `--test-option` This fixes #4803, #4643, #4766, and #5416.
|
Currently it is impossible to pass any arguments to a test suite that is run via
new-test
since they are interpreted as targets (regardless of how many--
you add in between).There is the question of what should happen if multiple test suites are run. Personally, I would prefer if the arguments are just passed to all of them in that case but I’m also fine with an error or whatever else as long as I have the possibility to specify the test suite explicitly.
The text was updated successfully, but these errors were encountered: