Skip to content

The Parser for ModuleRenaming fails to skip some spaces #4864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ekmett opened this issue Nov 5, 2017 · 2 comments · Fixed by #5514
Closed

The Parser for ModuleRenaming fails to skip some spaces #4864

ekmett opened this issue Nov 5, 2017 · 2 comments · Fixed by #5514
Assignees
@ezyang
Labels
Cabal: Backpack

Comments

@ekmett
Copy link
Member

ekmett commented Nov 5, 2017

(Foo as Bar) parses, ( Foo as Bar) does not.

This leads to particularly awkward multi-line mixins.

It just looks like a couple of calls to Parse.skipSpaces were missed.
@ezyang ezyang self-assigned this Nov 5, 2017
@danidiaz danidiaz mentioned this issue Jan 8, 2021
Merged
@fgaz
Copy link
Member

fgaz commented Feb 15, 2021

Was this fixed in #5293 ?

@phadej
Copy link
Collaborator

phadej commented Feb 15, 2021

I think so. (ditto other issue)

@fgaz fgaz linked a pull request Feb 15, 2021 that will close this issue
Piyush whitespace issue #5514
Merged
@fgaz fgaz closed this as completed Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ezyang ezyang

Labels
Cabal: Backpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Piyush whitespace issue phadej/cabal
4 participants
@ezyang @phadej @ekmett @fgaz