Skip to content

Removed obsolete warning about mixins in the doc #7231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

danidiaz
Copy link
Collaborator

@danidiaz danidiaz commented Jan 8, 2021

The documentation for the "mixins:" field still featured an obsolete warning about a parsing bug which was solved in #5293 and #5292.

I have verified that it indeed works now.

Open issues about seemingly the same bug: #5150, #4864.

@fgaz
Copy link
Member

fgaz commented Jan 14, 2021

Same as the other pr, try rebasing

@phadej
Copy link
Collaborator

phadej commented Jan 15, 2021

Why this (and #7233) have cherry-picked commits from master? Is this something weird git did?

@danidiaz
Copy link
Collaborator Author

@phadej I didn't cherry-pick, but I must have made a mess during the rebase.

@danidiaz danidiaz force-pushed the doc_obsolete_mixins_warning branch from 91d9111 to ebb04ee Compare January 24, 2021 21:55
@danidiaz
Copy link
Collaborator Author

The rebase trouble should be fixed now, ditto for #7233.

Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is fixed only for cabal-version (the .cabal spec) 3.0. For compatibility, it's still there when cabal-version is set to <3.0. Please write that in the note instead of deleting it

@danidiaz danidiaz force-pushed the doc_obsolete_mixins_warning branch from ebb04ee to 2eba8c8 Compare February 15, 2021 14:12
@danidiaz
Copy link
Collaborator Author

Modified the note.

@jneira
Copy link
Member

jneira commented Feb 12, 2022

@Mikolaj this is good to merge but ci is in a unfinshed state 🤔
More checks has been added after the last succesfull run, but i dont see the option to merge to master to force a new run

@Mikolaj
Copy link
Member

Mikolaj commented Feb 12, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Feb 12, 2022

rebase

✅ Branch has been successfully rebased

@jneira jneira force-pushed the doc_obsolete_mixins_warning branch from 291661d to a1c833a Compare February 12, 2022 21:50
@Mikolaj
Copy link
Member

Mikolaj commented Feb 12, 2022

Let's see...

@jneira
Copy link
Member

jneira commented Feb 12, 2022

oh i forgot about mergifiy, nice

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Feb 12, 2022
@mergify mergify bot merged commit 7d66cea into haskell:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants