Skip to content

Entry builddir: <dir> silently ignored from cabal.project #7941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andreasabel opened this issue Jan 30, 2022 · 4 comments · Fixed by #8949
Closed

Entry builddir: <dir> silently ignored from cabal.project #7941

andreasabel opened this issue Jan 30, 2022 · 4 comments · Fixed by #8949
Assignees
@andreabedini
Labels
attention: pr-welcome re: builddir re: error-message Concerning error messages delivered to the user re: project-file Concerning cabal.project files

Comments

@andreasabel
Copy link
Member

Entries builddir: <dir> are silently dropped from cabal.project. (Context: #7368 (comment))

Whether they should be supported or not is discussed in #5271.

In the meantime, while that issue cooks, cabal should give a warning that builddir: entries are ignored/unknown/unsupported.
@andreasabel andreasabel added re: project-file Concerning cabal.project files re: builddir labels Jan 30, 2022
@jneira jneira added the re: error-message Concerning error messages delivered to the user label Feb 15, 2022
@ulysses4ever ulysses4ever changed the title Entry builddir: <dir> silently dropped from cabal.project Entry builddir: <dir> silently ignored from cabal.project Jul 17, 2022
@ulysses4ever
Copy link
Collaborator

Historical reference: the --builddir option (and the docs saying that it won't work from inside cabal.project) comes from #4124 where the description reads:

It's not too easy to make the value of 'dist-dir' (currently builddir -- u4e) saveable
to the cabal.project file, as we'd prefer to load directly
from the cache if cabal.project is not updated.

I should confess I don't understand what it means though.

@ulysses4ever ulysses4ever mentioned this issue May 13, 2023
Closed
@andreabedini andreabedini self-assigned this May 17, 2023
andreabedini added a commit to andreabedini/cabal that referenced this issue May 17, 2023
@andreabedini
Warn if builddir is going to be ignored.
6373b25 
Closes: haskell#7941
@andreabedini andreabedini mentioned this issue May 17, 2023
Merged
4 tasks
@Kleidukos
Copy link
Member

Kleidukos commented May 17, 2023 •
edited
Loading

@mixphix didn't you stumble on this by any chance?

@ulysses4ever
Copy link
Collaborator

@Kleidukos you may be thinking of #8947

@mixphix
Copy link
Contributor

mixphix commented May 17, 2023

Yeah, which I learned was a duplicate of #5271. It turns out that HLS puts things into dist-newstyle anyway, so I've given up on the tractability of what I was trying to do there.

andreabedini added a commit to andreabedini/cabal that referenced this issue May 22, 2023
@andreabedini
Warn if builddir is going to be ignored.
74c46ae 
builddir can only be specified from the command line.

Closes: haskell#7941
andreabedini added a commit to andreabedini/cabal that referenced this issue May 27, 2023
@andreabedini
Warn if builddir is going to be ignored.
c1f5b04 
builddir can only be specified from the command line.

Closes: haskell#7941
andreabedini added a commit to andreabedini/cabal that referenced this issue May 29, 2023
@andreabedini
Warn if builddir is going to be ignored.
eeb90a1 
builddir can only be specified from the command line.

Closes: haskell#7941
andreabedini added a commit to andreabedini/cabal that referenced this issue May 29, 2023
@andreabedini
Warn if builddir is going to be ignored.
e1af417 
builddir can only be specified from the command line.

Closes: haskell#7941
@mergify mergify bot closed this as completed in #8949 May 31, 2023
mergify bot pushed a commit that referenced this issue May 31, 2023
@andreabedini
Warn if builddir is going to be ignored (#8949)
eaa38b6 
* Unify the default project with the implicit one

Passing --ignore-project made cabal use `defaultProject` which is not
quite identical to the one used when cabal.project is missing
(`defaultImplifictProjectConfig`). There is no reason the two should be
different.

* Warn if builddir is going to be ignored.

builddir can only be specified from the command line.

Closes: #7941

* Clarify which project option can only be passed from the command line

* Add note about reading the project configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreabedini andreabedini

Labels
attention: pr-welcome re: builddir re: error-message Concerning error messages delivered to the user re: project-file Concerning cabal.project files
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn if builddir is going to be ignored andreabedini/cabal
7 participants
@jneira @andreabedini @andreasabel @ulysses4ever @fgaz @mixphix @Kleidukos