Changelogs for 3.12.1.0 #10124

geekosaur · 2024-06-19T01:20:30Z

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

Patches conform to the coding conventions.
Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Closes #10086

geekosaur · 2024-06-19T01:50:11Z

Someone should verify my choices for what counted as major vs. minor changes.
I have no idea what the whitespace job is looking for. I tried to copy release-notes/Cabal-3.12.0.0.md's format.

geekosaur · 2024-06-19T02:08:41Z

I was surprised that only 6 changelog entries were created for cabal-install since the WIP changelog was last updated. Is that correct? (It might be, since changelog.d was pretty empty.)
Should I go ahead and rename the WIP changelog to its final name?

Mikolaj · 2024-06-19T06:29:33Z

whitespace

Isn't this a whitespace bug?

"Cabal will succeed if "

I was surprised that only 6 changelog entries were created

I've commented in the channel.

Should I go ahead and rename the WIP changelog to its final name?

Absolutely, though maybe after the missing changelogs are brought back.

ulysses4ever · 2024-06-19T12:45:22Z

Could someone please check that this is addressed: #10086

ulysses4ever

Copy-editing Cabal (the lib) notes.

release-notes/Cabal-3.12.1.0.md

ulysses4ever

Ibid (for cabal-install)

release-notes/cabal-install-3.12.1.0.md

ulysses4ever · 2024-06-19T18:37:51Z

PSA: the PR's merged into 3.12 branch can be browsed via https://github.com/haskell/cabal/pulls?q=is%3Apr+sort%3Aupdated-desc+base%3A3.12+is%3Aclosed

I think #10123 deserves a mention to make the users more aware of performance improvements they can expect. This could increase the number of early adopters.

I'd also mention #9917 along the following lines in cabal-install release notes:

This is the first release compatible with Cabal 3.12 distributed with GHC 9.10. It unlocks custom setup builds with GHC 9.10. #9917

ulysses4ever · 2024-06-19T18:53:24Z

I think #10108 is also missing a changelog. Could we add an entry in the list manually?

geekosaur · 2024-06-19T18:54:34Z

I did for the error messages. Speak now or forever hold your peace!

Co-authored-by: Artem Pelenitsyn <[email protected]>

ulysses4ever · 2024-06-19T19:38:50Z

Can't promise the forever part :-) I may have another look at the PR list I referenced above

geekosaur · 2024-06-19T19:50:43Z

It's "forever" once I hand it off to Mergify 😀

ulysses4ever · 2024-06-20T00:49:55Z

So, shall we move forward?

geekosaur · 2024-06-20T00:53:43Z

I put it on the docket for tomorrow.

release-notes/cabal-install-3.12.1.0.md

release-notes/Cabal-3.12.1.0.md

release-notes/cabal-install-3.12.1.0.md

Co-authored-by: ffaf1 <[email protected]>

geekosaur · 2024-06-20T23:11:23Z

Are we go?

ulysses4ever · 2024-06-21T00:15:34Z

I think we should

geekosaur · 2024-06-21T14:37:58Z

@mergify backport master

mergify · 2024-06-21T14:38:01Z

backport master

✅ Backports have been created

#10132 Changelogs for 3.12.1.0 (backport #10124) has been created for branch master but encountered conflicts

* changelog for 3.12.1.0 * fixup! changelog for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 Co-authored-by: Artem Pelenitsyn <[email protected]> * fixup! changelog for 3.12.1.0 * fixup! changelog for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 Co-authored-by: ffaf1 <[email protected]> * fixup! Changelogs for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 --------- Co-authored-by: Artem Pelenitsyn <[email protected]> Co-authored-by: ffaf1 <[email protected]> (cherry picked from commit 2067ed1) # Conflicts: # release-notes/Cabal-3.12.0.0.md

* Changelogs for 3.12.1.0 (#10124) * changelog for 3.12.1.0 * fixup! changelog for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 Co-authored-by: Artem Pelenitsyn <[email protected]> * fixup! changelog for 3.12.1.0 * fixup! changelog for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 Co-authored-by: ffaf1 <[email protected]> * fixup! Changelogs for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 --------- Co-authored-by: Artem Pelenitsyn <[email protected]> Co-authored-by: ffaf1 <[email protected]> (cherry picked from commit 2067ed1) # Conflicts: # release-notes/Cabal-3.12.0.0.md * fixup! Changelogs for 3.12.1.0 (backport #10124) --------- Co-authored-by: brandon s allbery kf8nh <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Changelogs for 3.12.1.0 (haskell#10124) * changelog for 3.12.1.0 * fixup! changelog for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 Co-authored-by: Artem Pelenitsyn <[email protected]> * fixup! changelog for 3.12.1.0 * fixup! changelog for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 Co-authored-by: ffaf1 <[email protected]> * fixup! Changelogs for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 --------- Co-authored-by: Artem Pelenitsyn <[email protected]> Co-authored-by: ffaf1 <[email protected]> (cherry picked from commit 2067ed1) # Conflicts: # release-notes/Cabal-3.12.0.0.md * fixup! Changelogs for 3.12.1.0 (backport haskell#10124) --------- Co-authored-by: brandon s allbery kf8nh <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

geekosaur added attention: needs-review attention: backport after release labels Jun 19, 2024

geekosaur force-pushed the changelog-3.12.1.0 branch 2 times, most recently from 56b3547 to 3bfbdf2 Compare June 19, 2024 01:27

ulysses4ever mentioned this pull request Jun 19, 2024

3.12.1.0 — a minor release of Cabal and friends #9885

Closed

18 tasks

ulysses4ever added the release label Jun 19, 2024

geekosaur force-pushed the changelog-3.12.1.0 branch from 3bfbdf2 to 864fbc2 Compare June 19, 2024 18:18

geekosaur linked an issue Jun 19, 2024 that may be closed by this pull request

Changelog for Cabal 3.12 is missing mention of error codes #10086

Closed

changelog for 3.12.1.0

e54a93c

geekosaur force-pushed the changelog-3.12.1.0 branch from 864fbc2 to e54a93c Compare June 19, 2024 18:24

ulysses4ever reviewed Jun 19, 2024

View reviewed changes

ulysses4ever approved these changes Jun 19, 2024

View reviewed changes

geekosaur and others added 3 commits June 19, 2024 15:03

fixup! changelog for 3.12.1.0

ec06336

fixup! Changelogs for 3.12.1.0

8a3885b

Co-authored-by: Artem Pelenitsyn <[email protected]>

fixup! changelog for 3.12.1.0

748834d

ysangkok reviewed Jun 20, 2024

View reviewed changes

release-notes/cabal-install-3.12.1.0.md Outdated Show resolved Hide resolved

fixup! changelog for 3.12.1.0

3297a3f

ffaf1 approved these changes Jun 20, 2024

View reviewed changes

release-notes/Cabal-3.12.1.0.md Outdated Show resolved Hide resolved

release-notes/Cabal-3.12.1.0.md Outdated Show resolved Hide resolved

release-notes/cabal-install-3.12.1.0.md Show resolved Hide resolved

geekosaur and others added 4 commits June 20, 2024 14:04

fixup! Changelogs for 3.12.1.0

56995b6

Co-authored-by: ffaf1 <[email protected]>

fixup! Changelogs for 3.12.1.0

38b207b

fixup! Changelogs for 3.12.1.0

89b3434

fixup! Changelogs for 3.12.1.0

4564220

geekosaur added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review labels Jun 21, 2024

mergify bot merged commit 2067ed1 into 3.12 Jun 21, 2024

mergify bot deleted the changelog-3.12.1.0 branch June 21, 2024 02:55

mergify bot mentioned this pull request Jun 21, 2024

Changelogs for 3.12.1.0 (backport #10124) #10132

Merged

2 tasks

geekosaur added a commit that referenced this pull request Jun 21, 2024

fixup! Changelogs for 3.12.1.0 (backport #10124)

9a8f2b8

mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jun 23, 2024

Changelogs for 3.12.1.0 #10124

Changelogs for 3.12.1.0 #10124

Uh oh!

Conversation

geekosaur commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geekosaur commented Jun 19, 2024

Uh oh!

geekosaur commented Jun 19, 2024

Uh oh!

Mikolaj commented Jun 19, 2024

Uh oh!

ulysses4ever commented Jun 19, 2024

Uh oh!

ulysses4ever left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ulysses4ever left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ulysses4ever commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ulysses4ever commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geekosaur commented Jun 19, 2024

Uh oh!

ulysses4ever commented Jun 19, 2024

Uh oh!

geekosaur commented Jun 19, 2024

Uh oh!

ulysses4ever commented Jun 20, 2024

Uh oh!

geekosaur commented Jun 20, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geekosaur commented Jun 20, 2024

Uh oh!

ulysses4ever commented Jun 21, 2024

Uh oh!

geekosaur commented Jun 21, 2024

Uh oh!

mergify bot commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Uh oh!

geekosaur commented Jun 19, 2024 •

edited

Loading

ulysses4ever commented Jun 19, 2024 •

edited

Loading

ulysses4ever commented Jun 19, 2024 •

edited

Loading

mergify bot commented Jun 21, 2024 •

edited

Loading