Skip to content

Conversation

geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Jul 25, 2025

Simply disabling or removing the step causes all non-Windows to fail, so we now skip it only on Windows.
This replaces Artem's PR #11086, which GitHub refused to let me reopen for some reason.


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Simply disabling the step causes all non-Windows to fail, so we
now skip it only on Windows.
@geekosaur
Copy link
Collaborator Author

Looks successful, @ulysses4ever.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jul 26, 2025
mergify bot added a commit that referenced this pull request Jul 26, 2025
@mergify mergify bot merged commit f2718c7 into haskell:master Jul 26, 2025
55 checks passed
@geekosaur
Copy link
Collaborator Author

I should probably mention that I set priority: high because it's a CI fix (we hope!)… but the fact that several PRs went in with only a Mac bobble before this landed suggests it might not be necessary and possibly only looks like it solved the problem. ☹️

@geekosaur
Copy link
Collaborator Author

geekosaur commented Jul 30, 2025

I've just discovered something odd: this isn't present at all in validate-actions, yet its CI passes (all the tests involving local Git checkouts to e.g. test source-repository-package should be failing, per #8546). Additionally, disabling that for Windows didn't cause any new tests to fail . At the time I wondered if we were already skipping all such tests on Windows for some reason, but now I'm suspicious. Especially given my previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-backport 3.16 merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge priority: high 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants