Minimal rebuilds for add-source dependencies #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor out the parts that are used to list all source files mentioned in a package description.
The change doesn't affect existing code.
|
Some small comments otherwise everything looks good! |
23Skidoo
added a commit
that referenced
this pull request
Apr 26, 2013
Minimal rebuilds for add-source dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1121.
Implemented by remembering timestamps for all add-source dependencies in a timestamp file,
.cabal-sandbox/add-source-timestamps.reinstallAddSourceDepsnow looks at the timestamp file record and the timestamps of the source files of a given add-source dependency to decide whether it is to be reinstalled. The timestamp record is first added bysandbox add-sourceand can later be updated/removed byreinstallAddSourceDeps/sandbox delete-source. User is allowed to (re)install add-source deps manually withcabal install [--reinstall], so this scheme sometimes errs on the side of caution.In the future I'd like to get rid of the timestamp file and just keep that info in the index (so that there is less chance that it goes out of sync).