Fixes HTTP{S} auth when using wget #2764
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…[Enables workaround for haskell#2761]
|
Do other transports (curl, PowerShell) also need to be updated? |
|
@23Skidoo I have no idea about PowerShell. I don't believe curl takes auth information in the URL. It might be helpful as a separate PR to pull that out of the URI record and pass it to curl with the proper flags. |
|
One catch: one MUST NOT pass the password on the |
|
So what's the conclusion here? |
|
As @drbo says, passing the password on the command line is problematic from the security standpoint and we should use |
23Skidoo
referenced
this pull request
in bennofs/cabal
Nov 3, 2015
This patch was tested with curl, wget and plain-http, but it's still untested on powershell. The wget implementation will only work if the available wget supports the `--method` switch.
|
Superseded by #2890. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wgetallows usernames and passwords to be encoded in URLs, and supports HTTPS. Thus, usinghttp-transport: wgetin the cabal configuration should permit the use of password-protected HTTPS hackage repositories. But because the arguments to wget are constructed using theShowinstance forNetwork.URI.URI, password information in the repository URL is replaced with..., resulting in authentication failures. This PR corrects that by using theNetwork.URI.uriToStringfunction to construct the URL argument to wget.It fixes issue #2763 and should be considered to solve issue #2761.