Fix bug in dependency solver stanza preferences #3480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grayjay
force-pushed
the
stanza-preferences
branch
from
437caea to
3242a47
Compare
Previously, stanza choices were set to "weak" even when the preference did not apply.
grayjay
force-pushed
the
stanza-preferences
branch
from
3242a47 to
463ebb9
Compare
|
/cc @kosmikus |
|
LGTM. |
|
Merged, thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit creates a newtype for the weak/trivial attribute of package flags and stanzas.
The second commit fixes a bug in dependency solver stanza preferences. Previously, stanza choices were set to "weak" even when the stanza preference did not apply. See #3453 (comment).
@kosmikus Does it make sense to call the newtype
WeakOrTrivial? I'm still not completely sure I understand the meaning of the weak/trivial fields in the solver'sFChoiceandSChoicenodes.