Give an explicit message when SIGSEGV happens. #3712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ezyang, thanks for your PR! By analyzing the annotation information on this pull request, we identified @dcoutts and @BardurArantsson to be potential reviewers |
|
LGTM. |
|
👍 |
|
Unfortunately, the patch doesn't work. Investigating. |
|
OK, found the bug. |
ezyang
force-pushed
the
pr/setup-segfault-msg
branch
from
44b57e5 to
64b6ec0
Compare
|
Heh, the Windows version of the test case explodes in an... interesting way. Let me see if I can tweak it. |
ezyang
force-pushed
the
pr/setup-segfault-msg
branch
2 times, most recently
from
b600a2b to
4e3fc54
Compare
Fixes haskell#767. Signed-off-by: Edward Z. Yang <[email protected]>
ezyang
force-pushed
the
pr/setup-segfault-msg
branch
from
4e3fc54 to
b45df92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #767.
Signed-off-by: Edward Z. Yang [email protected]