Add a new field to solver Done nodes, and simplify Explore.exploreLog. #3820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | SChoiceF QSN a WeakOrTrivial (WeightedPSQ [Weight] Bool b) | ||
| | GoalChoiceF (PSQ (Goal QPN) b) | ||
| | DoneF RevDepMap | ||
| data TreeF a b c = |
There was a problem hiding this comment.
Tell me what the parameters mean!
|
I don't really know what is going on algorithmically, but I can at least ask for docs on the types ;) |
grayjay
force-pushed
the
done-node-field
branch
from
a1d450e to
6b7c536
Compare
|
Lovely, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #2917. The new field is only used for some refactoring in this PR, but #2917 uses it to store the install plan scores.
/cc @kosmikus