Skip to content

Reduce path lengths for temp package src and build dirs #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

dcoutts
Copy link
Contributor

@dcoutts dcoutts commented Oct 12, 2016

This is for paths under $dist/tmp/ where we unpack package source tarballs and build them. This is for packages destined for the store. The names of these tmp dirs don't matter since they're guaranteed to be unique, so we only need short identifiers. So stop using full package names, and put the build artefacts in their own dir, rather than using a dist dir under the src dir.

This is intended to address #3972

This is for paths under $dist/tmp/ where we unpack package source
tarballs and build them. This is for packages destined for the store.
The names of these tmp dirs don't matter since they're guaranteed to be
unique, so we only need short identifiers. So stop using full package
names, and put the build artifacts in their own dir, rather than using a
dist dir under the src dir.
@mention-bot
Copy link

@dcoutts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ezyang, @23Skidoo and @arianvp to be potential reviewers.

Copy link
Member

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@23Skidoo 23Skidoo merged commit 850b68b into haskell:master Oct 12, 2016
@23Skidoo
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants