-
Notifications
You must be signed in to change notification settings - Fork 710
Re-enable Travis testing other versions of GHC. #3989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure, but d36a2d7 might be relevant to bring back? |
It's a good thought, but building with GHC HEAD is broken due to broken hackage-security, and I don't feel like enabling it while it is broken. |
-- Test that Cabal parses '^>=' operator correctly. | ||
-- Don't run this for GHC 7.0/7.2, which doesn't have a recent | ||
-- enough version of pretty. (But this is pretty dumb.) | ||
tc "CaretOperator" . whenGhcVersion (>= mkVersion [7,3])$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have incorrect lowerbound?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's just that these tests run independently of the Hackage index, so the dep solver is only able to solve for boot packages. In 7.2/7.0 the boot version is lower than the caret lower bound.
This increases our test coverage for using Cabal with GHC 7.0, 7.2 and HEAD. Signed-off-by: Edward Z. Yang <[email protected]>
4e8e6bd
to
5ab7191
Compare
This is marked green, but Travis tests actually didn't run. |
It was green; I accidentally triggered a rebuild and then cancelled it. |
OK, it's just that GitHub only shows the AppVeyor check as succeeded. I guess this can go in then? |
Yes, though if you want to feel better about it, restart the build ;) |
Nope, I trust you. |
This increases our test coverage for using Cabal with GHC 7.0, 7.2
and HEAD.
Signed-off-by: Edward Z. Yang [email protected]