Skip to content

Re-enable Travis testing other versions of GHC. #3989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 17, 2016

This increases our test coverage for using Cabal with GHC 7.0, 7.2
and HEAD.

Signed-off-by: Edward Z. Yang [email protected]

@mention-bot
Copy link

@ezyang, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hvr, @quchen and @23Skidoo to be potential reviewers.

@BardurArantsson
Copy link
Collaborator

Not sure, but d36a2d7 might be relevant to bring back?

@ezyang
Copy link
Contributor Author

ezyang commented Oct 17, 2016

It's a good thought, but building with GHC HEAD is broken due to broken hackage-security, and I don't feel like enabling it while it is broken.

-- Test that Cabal parses '^>=' operator correctly.
-- Don't run this for GHC 7.0/7.2, which doesn't have a recent
-- enough version of pretty. (But this is pretty dumb.)
tc "CaretOperator" . whenGhcVersion (>= mkVersion [7,3])$
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have incorrect lowerbound?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's just that these tests run independently of the Hackage index, so the dep solver is only able to solve for boot packages. In 7.2/7.0 the boot version is lower than the caret lower bound.

This increases our test coverage for using Cabal with GHC 7.0, 7.2
and HEAD.

Signed-off-by: Edward Z. Yang <[email protected]>
@ezyang ezyang force-pushed the pr/travis-with-ghc branch from 4e8e6bd to 5ab7191 Compare October 17, 2016 21:19
@23Skidoo
Copy link
Member

This is marked green, but Travis tests actually didn't run.

@ezyang
Copy link
Contributor Author

ezyang commented Oct 18, 2016

It was green; I accidentally triggered a rebuild and then cancelled it.

@23Skidoo
Copy link
Member

OK, it's just that GitHub only shows the AppVeyor check as succeeded. I guess this can go in then?

@ezyang
Copy link
Contributor Author

ezyang commented Oct 18, 2016

Yes, though if you want to feel better about it, restart the build ;)

@23Skidoo 23Skidoo merged commit d8c1017 into haskell:master Oct 18, 2016
@23Skidoo
Copy link
Member

Nope, I trust you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants