Update installedPkgs with internal deps, fix a bug #4006
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <[email protected]>
Previously, we unconditionally blasted in all packages, even if our component didn't actually depend on them. This fixes haskell#2971. Also, added a test T2971a which is the opposite problem; previously we didn't bring in include-dirs from internal libraries. That was fixed by the previous commit. Signed-off-by: Edward Z. Yang <[email protected]>
dcoutts
reviewed
Oct 20, 2016
| @@ -96,18 +99,21 @@ build pkg_descr lbi flags suffixes = do | |||
|
|
|||
| internalPackageDB <- createInternalPackageDB verbosity lbi distPref | |||
|
|
|||
| for_ componentsToBuild $ \target -> do | |||
| foldM_ `flip` installedPkgs lbi `flip` componentsToBuild $ \index target -> do | |||
There was a problem hiding this comment.
Any chance we can write this so someone might understand it?
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only consider dependencies in closure when computing -I on hsc2hs
Previously, we unconditionally blasted in all packages, even
if our component didn't actually depend on them.
This fixes #2971.
Also, added a test T2971a which is the opposite problem; previously
we didn't bring in include-dirs from internal libraries. That
was fixed by the previous commit.
This branch is based off of #4003 so ignore those commits.