Fix install of packages bundling generated source in dist/ #4012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages like `alex` include pre-generated lexer/parser source in their source tarball as e.g. dist/build/alex/alex-tmp/Scan.hs dist/build/alex/alex-tmp/Parser.hs to avoid having to have alex already installed before building alex... Unfortunately, 8dc39db broke packages relying on this accidental feature by changing where the distdir points to. This patch partly reverts that commit and therefore addresses the regression aspect of #4009.
dcoutts
approved these changes
Oct 20, 2016
|
Ahahahaha, so that's what it is. LGTM. |
23Skidoo
reviewed
Oct 20, 2016
| -- compatibility we put the dist dir within it | ||
| -- (i.e. tmp/src2345/foo-1.0/dist/). | ||
| -- | ||
| -- Unfortunately. a few custom Setup.hs scripts do not respect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages like
alexinclude pre-generated lexer/parser sourcein their source tarball as e.g.
dist/build/alex/alex-tmp/Scan.hs
dist/build/alex/alex-tmp/Parser.hs
to avoid having to have alex already installed before building
alex...
Unfortunately, 8dc39db broke
packages relying on this accidental feature by changing where the
distdir points to. This patch partly reverts that commit and
therefore addresses the regression aspect of #4009.