Skip to content

Add datadir env var before running the exe #4610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions cabal-install/Distribution/Client/CmdRun.hs
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,12 @@ import Distribution.Types.Executable
import Distribution.Types.UnqualComponentName
( UnqualComponentName, unUnqualComponentName )
import Distribution.Types.PackageDescription
( PackageDescription(executables) )
( PackageDescription(executables, dataDir) )
import Distribution.Simple.Program.Run
( runProgramInvocation, simpleProgramInvocation )
( runProgramInvocation, ProgramInvocation(..),
emptyProgramInvocation )
import Distribution.Simple.Build.PathsModule
( pkgPathEnvVar )
import Distribution.Types.PackageId
( PackageIdentifier(..) )

Expand All @@ -61,6 +64,8 @@ import Data.Function
( on )
import System.FilePath
( (</>) )
import System.Directory
( getCurrentDirectory )


runCommand :: CommandUI (ConfigFlags, ConfigExFlags, InstallFlags, HaddockFlags)
Expand Down Expand Up @@ -227,10 +232,17 @@ runAction (configFlags, configExFlags, installFlags, haddockFlags)
pkg
exe
</> exe
let args = drop 1 targetStrings
curDir <- getCurrentDirectory
let dataDirEnvVar = (pkgPathEnvVar (elabPkgDescription pkg) "datadir",
Just $ curDir </> dataDir (elabPkgDescription pkg))
args = drop 1 targetStrings
runProgramInvocation
verbosity
(simpleProgramInvocation exePath args)
emptyProgramInvocation {
progInvokePath = exePath,
progInvokeArgs = args,
progInvokeEnv = [dataDirEnvVar]
}
where
verbosity = fromFlagOrDefault normal (configVerbosity configFlags)
cliConfig = commandLineFlagsToProjectConfig
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: Datafiles
version: 1.0
build-type: Simple
cabal-version: >= 1.10
data-dir: data
data-files: hello.txt

executable foo
main-is: Main.hs
build-depends: base
default-language: Haskell2010
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import Paths_Datafiles

main = putStrLn =<< readFile =<< getDataFileName "hello.txt"

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# cabal new-run
Resolving dependencies...
Build profile: with-compiler: ghc-<GHCVER>, optimisation: NormalOptimisation
In order, the following will be built:
- Datafiles-1.0 (exe:foo) (first run)
Configuring executable 'foo' for Datafiles-1.0..
Preprocessing executable 'foo' for Datafiles-1.0..
Building executable 'foo' for Datafiles-1.0..
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
packages: .
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import Test.Cabal.Prelude
main = cabalTest $
cabal' "new-run" ["foo"] >>= assertOutputContains "Hello World"

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hello World