Implement preliminary support for new forward-compat scheme #4900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a provisional (i.e. hacky) retrofitted implementation of the forward-compat scheme described in haskell#4899 for the cabal-2.0 branch. This hack works by constructing a dummy package description in case the package description fails to be parsed via the standard parser, and we detect a new-style cabal-spec declaration.
hvr
added a commit
to hvr/cabal
that referenced
this pull request
Nov 24, 2017
This compares the request spec-version to the lib:Cabal's version in order to determine whether cabal is able to properly understand the package. If it's newer than the currently linked lib:Cabal version it's turned into a global `FailResult` which the solver treats as desired in terms of backtracking and error reporting. This is related to the new spec-version forward-compat scheme (see haskell#4899). This is complements haskell#4900 for the 2.0 branch.
3 tasks
|
Merged, thanks! |
hvr
added a commit
to hvr/cabal
that referenced
this pull request
Nov 24, 2017
This compares the request spec-version to the lib:Cabal's version in order to determine whether cabal is able to properly understand the package. If it's newer than the currently linked lib:Cabal version it's turned into a global `FailResult` which the solver treats as desired in terms of backtracking and error reporting. This is related to the new spec-version forward-compat scheme (see haskell#4899). This is complements haskell#4900 for the 2.0 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a provisional (i.e. hacky) retrofitted implementation of
the forward-compat scheme described in #4899 for the cabal-2.0 branch.
This hack works by constructing a dummy package description in case
the package description fails to be parsed via the standard parser,
and we detect a new-style cabal-spec declaration.