Unbreak the build with directory < 1.2.3.0. #4962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
phadej
approved these changes
Dec 19, 2017
phadej
reviewed
Dec 19, 2017
| #else | ||
|
|
||
| import Data.Time.Clock (UTCTime) | ||
| import System.IO (FilePath) |
There was a problem hiding this comment.
IIRC FIlePath is in Prelude: http://hackage.haskell.org/package/base-4.10.1.0/docs/Prelude.html#t:FilePath
23Skidoo
force-pushed
the
set-modification-time
branch
from
301c017 to
3f0d771
Compare
4 tasks
See haskell#4950 (comment) for context.
23Skidoo
force-pushed
the
set-modification-time
branch
from
3f0d771 to
7a6559a
Compare
Solver still sometimes picks 1.6.14 for some reason, and that version is broken on older GHCs.
11 tasks
4 tasks
|
This passed on Linux, I'll just go ahead and merge because a bunch of other stufff is blocked on this. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4950 (comment) for context.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!