Remove UnknownBuildType from BuildType
#5003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to haskell#4958 which opened up the opportunity to do this make-illegal-states-unrepresentable refactoring as well.
|
Why did we have it in the first place? |
|
Merged, thanks! |
|
@23Skidoo I think the original reasons can be inferred from the original comment attached to the removed constructor: basically defer error handling to |
phadej
added a commit
to phadej/cabal
that referenced
this pull request
Jan 31, 2018
Solves haskell#5087 Related to haskell#5003 Note: `buildable: ` field has `All` semantics. `scope: ` has `AnyPrivate` semantics. Both might be surprising, but are "logical". https://hackage.haskell.org/package/Cabal-2.0.1.1/docs/src/Distribution.PackageDescription.Parse.html#line-248
4 tasks
phadej
added a commit
to phadej/cabal
that referenced
this pull request
Jan 31, 2018
Solves haskell#5087 Related to haskell#5003 Note: `buildable: ` field has `All` semantics. `scope: ` has `AnyPrivate` semantics. Both might be surprising, but are "logical". https://hackage.haskell.org/package/Cabal-2.0.1.1/docs/src/Distribution.PackageDescription.Parse.html#line-248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #4958 which opened up the opportunity to do
this make-illegal-states-unrepresentable refactoring as well.