Implement ghc/cabal compatiblity matrix (#415) #5177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This injects lower-bound constraints on Cabal for custom setup dependencies to prevent the solver from selecting unsupported configurations. Previously we already added an absolute lower bound `Cabal >= 1.20` for nix-local builds, as that's the minimum version we need to be able to interact with custom Setup.hs scripts. This refines with logic by restricting that lower bound even more based on GHC version. This patch augments this with the following rules: - GHC 8.4+ constrains Cabal >= 2.2 - GHC 8.2 constrains Cabal >= 2.0 - GHC 8.0 constrains Cabal >= 1.24 - GHC 7.10 constrains Cabal >= 1.22 - (default constraint Cabal >= 1.20) This only affects nix-style local builds codepaths. (cherry picked from commit 71e797e)
(cherry picked from commit a503345)
(cherry picked from commit de323c1)
The `setup-custom2` tests implicit `setup-depends` which implies a `Cabal < 2` upper bound, which is incompatible with GHC 8.2 or later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #5165 to 2.2