Look for transitive setup dependency on Cabal when choosing Cabal spec version. (2.2) #5193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c version. Fixes haskell#4288. Previously, new-build only looked for a direct dependency on Cabal when choosing the spec version to use for running the setup script. When the setup script only had a transitive dependency on Cabal, cabal used the package's cabal-version field, which could easily differ from the actual Cabal dependency's version. Then cabal could pass flags to the setup script that weren't recognized by the Cabal dependency. This commit considers any setup dependency on Cabal when choosing the Cabal spec version. (cherry picked from commit ea01b9d)
(cherry picked from commit f4f382a)
|
I'm generally for including this in 2.2 since it fixes an issue, i.e. #4288 |
|
Sure, why not. |
|
Thanks, I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5170 cherry-picked onto 2.2.
@23Skidoo Do you think we should apply this to 2.2? It only affects new-build.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!