-
Notifications
You must be signed in to change notification settings - Fork 710
Backport deprecation warnings to 2.2 #5378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cabal/Cabal.cabal
Outdated
@@ -1,5 +1,5 @@ | |||
name: Cabal | |||
version: 2.2.0.1 | |||
version: 2.2.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why bump Cabal
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, added symbol. That should require third digit bump, patch (4th) level isn't enough.
Seems to have an error in the travis script, but I'm not sure how that works. |
Commands that should also get warnings:
|
|
I know, but not sure if that should come with a warning or not. |
I've just merged a PR adding a warning to |
Any that I'm not thinking of? |
|
Okay, adding those. Should I also backport 6922cfc in this PR? |
Please do. |
If |
Without sdist install won't work, so it'll be there by the time it changes. outdated? IThere's #4831. And anyway, their suggested option is to switch to |
There's still a nag for the
I could get behind the suggestion that |
Okay, I'll not give them to I mean, that warning is extremely not wrong and it only shows up in |
f4b5fdd
to
c05f79c
Compare
I was already working on this, but seeing @lspitzner's concerns in #5358 made me decide to wrap it up and make a PR.
To help ease the transition to 3.0 and the default new-build future, this backports the aliases and most importantly the warnings to ensure that people have time to update any scripts to use the aliases before the semantics would change.
Before this gets merged/released, if it does, I do want to come up with a list of all commands that need
new-
versions before 3.0 so that there will be all relevant warnings included.--
Please include the following checklist in your PR:
[ci skip]
is used to avoid triggering the build bots.