Skip to content

Added documentation for Backpack-related fields. #5385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2018

Conversation

danidiaz
Copy link
Collaborator

I added descriptions for the Backpack-related signatures: and mixins: fields, which were missing according to issue #4761.

The new entries don't explain Backpack in detail, but give the basic syntax and link to the GHC Wiki entry and to the GHC user guide for more information.

@hvr hvr requested a review from ezyang June 18, 2018 09:51
@hvr hvr added this to the 2.4 milestone Jun 18, 2018
@hvr
Copy link
Member

hvr commented Jun 18, 2018

That's awesome! Thanks for doing this. It'd be great if @ezyang as the authority on Backpack could sign it off...

@hvr
Copy link
Member

hvr commented Jun 18, 2018

@danidiaz could you add a note about the syntax infelicity w/ whitespaces in the mixin field (which will be addressed by #5293 either in cabal-version:2.4 or cabal-version:3.0 (however, cabal-version:2.0 and cabal-version:2.2 will keep requiring the extra whitespace forever) -- depending on how fast we get #5293 ready for merge)?

Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs look good, thank you very much for the contribution!

It mentions the issue of parsing failures caused by the presence of
blank spaces after opening parentheses.

See haskell#5150, haskell#5292, haskell#5293.
@23Skidoo
Copy link
Member

@ezyang approves, let's merge!

@23Skidoo 23Skidoo merged commit f2dd0ea into haskell:master Jun 19, 2018
@23Skidoo
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants