Add LibraryVisibility to InstalledPackageInfo #5815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch only modifies the datatype. The field is not filled with the correct visibility info yet. A ghc-pkg compiled with this patch is needed to actually record this information and properly test the visibility checks.
fgaz
force-pushed
the
library-visibility-ipi
branch
from
5c88c7a to
9f2867c
Compare
|
I guess this needs #5812 and corrections to GHC to properly test, so I'm in favor of merging this eagerly. If I read properly, the field isn't ever written with this change (as we never yet set it to not private), so this is safe to apply. |
OK. I assume it will be gated on the GHC version in the full implementation? |
|
@23Skidoo yes, in similar way we gate on e.g. different formats of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr only modifies the datatype. The field is not filled with the correct visibility info yet. We'll need a ghc-pkg compiled with this patch to actually record this information and properly test the visibility checks.
/cc @phadej @ezyang @23Skidoo
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!